From c4e01d0527eb727c2bc89356a437322b49c239de Mon Sep 17 00:00:00 2001 From: Michael Sarahan Date: Fri, 6 Dec 2024 13:42:50 -0600 Subject: [PATCH 1/2] remove certs and simplify telemetry summarize --- .github/workflows/pr.yaml | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 0cb21c4b00..c1bfa8c08e 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -37,10 +37,12 @@ jobs: runs-on: ubuntu-latest continue-on-error: true env: - OTEL_SERVICE_NAME: "pr-cuml" + OTEL_SERVICE_NAME: "pr-cuml" + SHARED_ACTIONS_REF: empty-certs + TELEMETRY_ENABLED: '1' steps: - name: Telemetry setup - uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@main + uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@empty-certs changed-files: secrets: inherit needs: telemetry-setup @@ -197,16 +199,12 @@ jobs: sccache -s; telemetry-summarize: - runs-on: ubuntu-latest + runs-on: linux-amd64-cpu4 needs: pr-builder if: always() continue-on-error: true + env: + SHARED_ACTIONS_REF: empty-certs steps: - - name: Load stashed telemetry env vars - uses: rapidsai/shared-actions/telemetry-dispatch-load-base-env-vars@main - with: - load_service_name: true - name: Telemetry summarize - uses: rapidsai/shared-actions/telemetry-dispatch-write-summary@main - with: - cert_concat: "${{ secrets.OTEL_EXPORTER_OTLP_CA_CERTIFICATE }};${{ secrets.OTEL_EXPORTER_OTLP_CLIENT_CERTIFICATE }};${{ secrets.OTEL_EXPORTER_OTLP_CLIENT_KEY }}" + uses: rapidsai/shared-actions/telemetry-dispatch-summarize@empty-certs From d74206c8dd41e8639e7ab7f17f3d22a48cd70198 Mon Sep 17 00:00:00 2001 From: Michael Sarahan Date: Fri, 6 Dec 2024 15:07:01 -0600 Subject: [PATCH 2/2] change telemetry-enabled string --- .github/workflows/pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index c1bfa8c08e..c8c817530b 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -39,7 +39,7 @@ jobs: env: OTEL_SERVICE_NAME: "pr-cuml" SHARED_ACTIONS_REF: empty-certs - TELEMETRY_ENABLED: '1' + TELEMETRY_ENABLED: true steps: - name: Telemetry setup uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@empty-certs