From 0d34eeffe9cc28276a740538a00111e1f6b1b2e4 Mon Sep 17 00:00:00 2001
From: Gregory Lee <grlee77@gmail.com>
Date: Wed, 15 Jan 2025 18:36:21 -0800
Subject: [PATCH] Apply suggestions from code review

restore prior numpy minimum version
---
 conda/environments/all_cuda-118_arch-x86_64.yaml | 2 +-
 conda/environments/all_cuda-125_arch-x86_64.yaml | 2 +-
 dependencies.yaml                                | 2 +-
 python/cucim/pyproject.toml                      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/conda/environments/all_cuda-118_arch-x86_64.yaml b/conda/environments/all_cuda-118_arch-x86_64.yaml
index 7cd4d7c7..c66bda1c 100644
--- a/conda/environments/all_cuda-118_arch-x86_64.yaml
+++ b/conda/environments/all_cuda-118_arch-x86_64.yaml
@@ -24,7 +24,7 @@ dependencies:
 - matplotlib-base>=3.7
 - nbsphinx
 - ninja
-- numpy>=1.24,<3.0a0
+- numpy>=1.23.4,<3.0a0
 - numpydoc>=1.5
 - nvcc_linux-64=11.8
 - openslide-python>=1.3.0
diff --git a/conda/environments/all_cuda-125_arch-x86_64.yaml b/conda/environments/all_cuda-125_arch-x86_64.yaml
index 237a4af5..dedab4a6 100644
--- a/conda/environments/all_cuda-125_arch-x86_64.yaml
+++ b/conda/environments/all_cuda-125_arch-x86_64.yaml
@@ -24,7 +24,7 @@ dependencies:
 - matplotlib-base>=3.7
 - nbsphinx
 - ninja
-- numpy>=1.24,<3.0a0
+- numpy>=1.23.4,<3.0a0
 - numpydoc>=1.5
 - openslide-python>=1.3.0
 - pip
diff --git a/dependencies.yaml b/dependencies.yaml
index 0e8a5ef6..dd6858e5 100644
--- a/dependencies.yaml
+++ b/dependencies.yaml
@@ -259,7 +259,7 @@ dependencies:
         packages:
           - click
           - lazy-loader>=0.4
-          - numpy>=1.24,<3.0a0
+          - numpy>=1.23.4,<3.0a0
           - scikit-image>=0.19.0,<0.26.0a0
           - scipy>=1.11.2
       - output_types: conda
diff --git a/python/cucim/pyproject.toml b/python/cucim/pyproject.toml
index 4f444279..d59f852f 100644
--- a/python/cucim/pyproject.toml
+++ b/python/cucim/pyproject.toml
@@ -27,7 +27,7 @@ dependencies = [
     "click",
     "cupy-cuda11x>=12.0.0",
     "lazy-loader>=0.4",
-    "numpy>=1.24,<3.0a0",
+    "numpy>=1.23.4,<3.0a0",
     "scikit-image>=0.19.0,<0.26.0a0",
     "scipy>=1.11.2",
 ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.