[SURE-9588] Issue setting folder S3 on etcd backups

[aldelsa]

Hi,
We are trying to configure the etcd backup using S3 bucket parameters in the RKE2ControlPlane manifest:

  etcd:
      backupConfig:
        retention: "10"
        scheduleCron: "*/3 * * * *"
        s3:
          bucket: backups-rancher
          endpoint: test-rancher.com
          folder: backup
          enforceSslVerify: true
          s3CredentialSecret:
            apiVersion: v1
            kind: Secret
            namespace: rke2test
            name: creds-etcd-backup

The problem is the next part of the code:

cluster-api-provider-rke2/pkg/rke2/config.go

Line 322 in 3d7df66

rke2ServerConfig.EtcdSnapshotDir = opts.ServerConfig.Etcd.BackupConfig.S3.Folder

If I use that s3 folder, I get "directory does not exist" message from rke2-server service because that folder does not exist on the machine for etcd backup, but it exists in my bucket.

The parameter folder should be independent from the EtcdSnapshotDir.

Thanks

[aldelsa]

I found this PR #278 @furkatgofurov7 but I don't understand the reason of that.

[furkatgofurov7]

I found this PR #278 @furkatgofurov7 but I don't understand the reason of that.

@aldelsa thanks for reporting the issue. I opened #549 which reverts the commit (the initial idea was to differentiate the backup location that is later consumed by other project, however it was not a correct assumption to change it the way it is now), PTAL and let me know if it solves your issue.