You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The API, which is nearly 100% compliant to RKE2 options, uses some fields that negate something. Example: controlplanev1.EtcdBackupConfig struct has a DisableAutomaticSnapshots bool field.
Should we keep these negations or should we change the API to something like: EnableAutomaticSnapshots.
My opinion is so:
We should stick to something very similar to RKE2 command line config upstream to avoid disturbing our users.
We should consider the default values ( in the case of DisableAutomaticSnapshots the default is to have the snapshots enabled, meaning the value is false). Meaning if the user does not specify this field, it should be considered as false which is indeed the right value by default. Changing this would mean more complexity in boolean default value handling.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
The API, which is nearly 100% compliant to RKE2 options, uses some fields that negate something. Example:
controlplanev1.EtcdBackupConfig
struct has aDisableAutomaticSnapshots
bool field.Should we keep these negations or should we change the API to something like:
EnableAutomaticSnapshots
.My opinion is so:
DisableAutomaticSnapshots
the default is to have the snapshots enabled, meaning the value isfalse
). Meaning if the user does not specify this field, it should be considered asfalse
which is indeed the right value by default. Changing this would mean more complexity in boolean default value handling.Beta Was this translation helpful? Give feedback.
All reactions