Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Do not package libmount &c #8049

Open
mook-as opened this issue Jan 7, 2025 · 2 comments
Open

Linux: Do not package libmount &c #8049

mook-as opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
component/ci Stories tied to CI for automation kind/bug Something isn't working platform/linux
Milestone

Comments

@mook-as
Copy link
Contributor

mook-as commented Jan 7, 2025

In 1.17 release we had issues on Linux because we included too many shared libraries as part of the qemu dependencies (in the zip file / AppImage) and it no longer ran on Tumbleweed. We worked around it by manually deleting the file from the release zip file.

We should review the set of libraries we ship and improve the blacklist / change it to a whitelist / something.

For reference: https://github.com/rancher-sandbox/rancher-desktop-qemu/blob/f294295f2af10db6525322b8cb4a49ac80c3945c/appdir-qemu.sh#L51-L67

@mook-as mook-as added this to the 1.18 milestone Jan 7, 2025
@mook-as mook-as added kind/bug Something isn't working platform/linux component/ci Stories tied to CI for automation labels Jan 7, 2025
@mook-as mook-as self-assigned this Jan 9, 2025
@mook-as
Copy link
Contributor Author

mook-as commented Jan 9, 2025

We should also figure out what the criteria is for blacklisting libraries and document that.

@mook-as
Copy link
Contributor Author

mook-as commented Jan 9, 2025

Tracked down the exclude list to have been derived from https://github.com/AppImageCommunity/pkg2appimage/blob/master/excludelist

Unfortunately, that now says to bundle GLib things. But digging further indicates that there's some argument on whether we should bundle that or not. It looks like bundling may break libsecret. But as we build on a newer system than some of the deploy targets (e.g. the Rocky users), we will need to ship it.


Trying to update the list to bundle the GLib files results in:

  libz.so.1
  libutil.so.1
  libm.so.6
  libgcc_s.so.1
  libpthread.so.0
  libc.so.6
  libresolv.so.2
  librt.so.1
  libuuid.so.1
  libdl.so.2

However, the AppImage doesn't work on Tumbleweed:

> ./rancher-desktop-9.main.1736453049.2503b4bd-Build2897.1.glibc2.34-x86_64.AppImage
rancher-desktop: symbol lookup error: /lib64/libgdk_pixbuf-2.0.so.0: undefined symbol: g_task_set_static_name

I think that means we need to do the reverse and bundle GLib (and see what issues we see).

I'm currently testing builds (from CI) against Rocky 9.5 + Tumbleweed, as being hopefully the two extremes.

@jandubois jandubois modified the milestones: 1.18, 1.17.1 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ci Stories tied to CI for automation kind/bug Something isn't working platform/linux
Projects
None yet
Development

No branches or pull requests

2 participants