Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory reset: stop all child processes #7653

Open
jandubois opened this issue Oct 17, 2024 · 2 comments · May be fixed by #8009
Open

Factory reset: stop all child processes #7653

jandubois opened this issue Oct 17, 2024 · 2 comments · May be fixed by #8009
Assignees
Milestone

Comments

@jandubois
Copy link
Member

jandubois commented Oct 17, 2024

This is an extension of #7587 to stop all child processes of Rancher Desktop regardless where the binaries are.

I've added some possible idea in rancher-sandbox/rancher-desktop-rdx-open-webui#22 to use either PID files, but ideally to trace subprocess relationships.

@mook-as
Copy link
Contributor

mook-as commented Nov 13, 2024

On Windows, the proper thing would probably to make sure we spawn child processes in a job and open it from rdctl when we do the factory reset to terminate the job. However, it's unclear how we'd assign the processes into the jobs from Node; calling Win32 directly seems like it would be annoying (since that means doing native bits again and it was painful last time).

Presumably on Linux/darwin we'd do something with process groups, though it's unclear to me at this point what the process group leader would be.

@mook-as
Copy link
Contributor

mook-as commented Dec 23, 2024

Summarizing the state of things:

Therefore the work left is to fix Linux to make it work again.

@mook-as mook-as linked a pull request Dec 25, 2024 that will close this issue
@jandubois jandubois modified the milestones: 1.17, 1.18 Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants