Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance comparison to JsonParse #75

Open
mitchhentges opened this issue Nov 17, 2016 · 2 comments
Open

Performance comparison to JsonParse #75

mitchhentges opened this issue Nov 17, 2016 · 2 comments

Comments

@mitchhentges
Copy link

minimal-json is super interesting, and if I knew about it earlier, I probably wouldn't have tried to make my own minimal parser.
However, JsonParse and JsonCompose now exist.

I've compared JsonParse to Jackson, and it outperforms it according to my tests.
Can you add JsonParse to the list of libraries that you compare minimal-json to?

@mitchhentges
Copy link
Author

mitchhentges commented Nov 18, 2016

I'm working on building my own pull request, but it looks like there's some maven issues:

  1. A certificate issue with maven: (https://repo.maven.apache.org/maven2): hostname in certificate didn't match: <repo.maven.apache.org> != <repo1.maven.org> OR <repo1.maven.org>
  2. minimal-json doesn't exist for ${project.version}
<dependency>
      <groupId>com.eclipsesource.minimal-json</groupId>
      <artifactId>minimal-json</artifactId>
      <version>${project.version}</version>
    </dependency>

I just hard-coded 0.9.4 in, but that probably shouldn't be PR'd in

@mitchhentges
Copy link
Author

Hmm, perhaps I imported the incorrect level of project before. Loading in the top-level pom.xml is working like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant