Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportBuilder.additional_js not being added to HTML report #95

Open
ChrisVereb opened this issue Sep 15, 2020 · 0 comments
Open

ReportBuilder.additional_js not being added to HTML report #95

ChrisVereb opened this issue Sep 15, 2020 · 0 comments

Comments

@ChrisVereb
Copy link

ChrisVereb commented Sep 15, 2020

I tried adding some additional javascript as both a string and file path, and it wasn't showing up at the footer of the HTML as expected. Looking at the ReportBuilder.additional_js= def, it looks like the @options key may be incorrect. Shouldn't @options[:additional_js=] be @options[:additional_js]? Making that change locally resulted in the additional javascript being included in the report.

Edit to add:
Workaround is to just access the options directly before building the report. Change "ReportBuilder.additional_js" to "ReportBuilder.options[:additional_js]"

@options[:additional_js=] = additional_js if additional_js.is_a? String

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant