-
-
Notifications
You must be signed in to change notification settings - Fork 3
/
Copy pathadd_foreign_key.rb
166 lines (152 loc) · 4.66 KB
/
add_foreign_key.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
# frozen_string_literal: true
module RuboCop
module Cop
module Migration
# Activate foreign key validation in a separate migration in PostgreSQL.
#
# To avoid blocking writes on both tables.
#
# @safety
# Only meaningful in PostgreSQL.
#
# @example
# # bad
# class AddForeignKeyFromArticlesToUsers < ActiveRecord::Migration[7.0]
# def change
# add_foreign_key :articles, :users
# end
# end
#
# # good
# class AddForeignKeyFromArticlesToUsersWithoutValidation < ActiveRecord::Migration[7.0]
# def change
# add_foreign_key :articles, :users, validate: false
# end
# end
#
# class ActivateForeignKeyValidationFromArticlesToUsers < ActiveRecord::Migration[7.0]
# def change
# validate_foreign_key :articles, :users
# end
# end
class AddForeignKey < RuboCop::Cop::Base
extend AutoCorrector
include RangeHelp
MSG = 'Activate foreign key validation in a separate migration in PostgreSQL.'
RESTRICT_ON_SEND = %i[
add_foreign_key
add_reference
].freeze
# @param node [RuboCop::AST::SendNode]
# @return [void]
def on_send(node)
return unless bad?(node)
add_offense(node) do |corrector|
autocorrect(corrector, node)
end
end
private
# @!method add_foreign_key_without_validate_option?(node)
# @param node [RuboCop::AST::SendNode]
# @return [Boolean]
def_node_matcher :add_foreign_key_without_validate_option?, <<~PATTERN
(send
nil?
:add_foreign_key
_
_
(hash
(pair
!(sym :validate)
_
)*
)?
)
PATTERN
# @!method option_validate_true_value_node_from_add_foreign_key(node)
# @param node [RuboCop::AST::SendNode]
# @return [RuboCop::AST::PairNode]
def_node_matcher :option_validate_true_value_node_from_add_foreign_key, <<~PATTERN
(send
nil?
:add_foreign_key
_
_
(hash
<
(pair
(sym :validate)
$true
)
...
>
)
)
PATTERN
# @!method option_foreign_key_true_node_from_add_reference(node)
# @param node [RuboCop::AST::SendNode]
# @return [RuboCop::AST::PairNode]
def_node_matcher :option_foreign_key_true_node_from_add_reference, <<~PATTERN
(send
nil?
:add_reference
_
_
(hash
<
$(pair
(sym :foreign_key)
true
)
...
>
)
)
PATTERN
# @param node [RuboCop::AST::SendNode]
# @return [Boolean]
def add_foreign_key_with_validate_option_true?(node)
option_validate_true_value_node_from_add_foreign_key(node)
end
# @param node [RuboCop::AST::SendNode]
# @return [Boolean]
def add_reference_with_validate_option_true?(node)
option_foreign_key_true_node_from_add_reference(node)
end
# @param corrector [RuboCop::Cop::Corrector]
# @param node [RuboCop::AST::SendNode]
# @return [void]
def autocorrect(
corrector,
node
)
if add_foreign_key_without_validate_option?(node)
corrector.insert_after(node.last_argument, ', validate: false')
elsif add_foreign_key_with_validate_option_true?(node)
corrector.replace(
option_validate_true_value_node_from_add_foreign_key(node),
'false'
)
elsif add_reference_with_validate_option_true?(node)
corrector.remove(
range_with_surrounding_comma(
range_with_surrounding_space(
option_foreign_key_true_node_from_add_reference(node).source_range,
side: :left
),
:left
)
)
end
end
# @param node [RuboCop::AST::SendNode]
# @return [Boolean]
def bad?(node)
add_foreign_key_without_validate_option?(node) ||
add_foreign_key_with_validate_option_true?(node) ||
add_reference_with_validate_option_true?(node)
end
end
end
end
end