Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to ES5/6 #149

Open
xgui3783 opened this issue Jul 27, 2018 · 1 comment
Open

Converting to ES5/6 #149

xgui3783 opened this issue Jul 27, 2018 · 1 comment

Comments

@xgui3783
Copy link
Collaborator

Hi! Thank you for getting back to us! <3

Hi all, I am wondering how much interest there is converting some/most of the code to ES5/6, mainly:

  • converting all vars to lets or consts
  • array methods such as [1,2,3].forEach(function(item){ console.log(item) })
  • arrow notation for functions, e.g., instead of [1,2,3].forEach(function (item) { console.log(item) }), having [1,2,3].forEach(item => console.log(item))

Is this a feature request or a bug report?

  • Please choose one of the labels on the right side and tag your issue :)

What is the current behaviour?

  • If this is a bug, please explain how to reproduce the problem
    • Which tools did you use in which sequence?
    • What is the resolution of your data? (Can you provide a link to your data?)
    • Do not include sensitive information.
    • Upload the browser error message if you are familiar with web developer tools.

What is the expected or desired behavior?

Version information (for bug reports)

  • Browser + version:
  • Your OS and version:
  • Paste the output of these commands:
node --version && npm --version
@katjaq
Copy link
Collaborator

katjaq commented Jul 30, 2018

Hello @xgui3783 ! This sounds like a great idea! Thank you so much!!!
All 3 of your suggestions 👍
And then also the Async/Await for all promises :)
You are a star!!! 🌟 ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants