Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 to v4 messages should only be signaled once per session #890

Closed
olivroy opened this issue Jun 19, 2024 · 2 comments · Fixed by #928
Closed

v3 to v4 messages should only be signaled once per session #890

olivroy opened this issue Jun 19, 2024 · 2 comments · Fixed by #928
Assignees
Labels
compat v3 to v4 transition

Comments

@olivroy
Copy link
Contributor

olivroy commented Jun 19, 2024

Thanks to #854, it is a little easier to know how to switch code from v3 to v4.

However, these messages can be a little overwhelming. As mentioned in #888 (comment)

I will wait for #851 to do this.

I will use cli to do this. https://rlang.r-lib.org/reference/abort.html#muffling-and-silencing-conditions

@olivroy olivroy added the compat v3 to v4 transition label Jun 19, 2024
@olivroy olivroy self-assigned this Jun 19, 2024
@mtennekes
Copy link
Member

Thx! #851 is done, but not sure what the relation with the messaging is...

@Nowosad
Copy link
Member

Nowosad commented Dec 25, 2024

I am now trying a lot of old tmap3 code -- I am very impressed with the messages helping to convert the code from the old syntax to the new one. Great work @olivroy @mtennekes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat v3 to v4 transition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants