Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect auth_token=NULL when used in install_github() #819

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

eeholmes
Copy link
Contributor

#818 SAML sign-on behavior with GitHub Enterprise makes install_github() impossible to use for GitHub repos on Enterprise accounts with multiple orgs. Users on one org will be unable to install R packages in public repos on other orgs in the Enterprise account. If remotes would respect auth_token=NULL then that can be put in the install instructions.

Currently when you use install_github(..., auth_token=NULL), remotes does not fully respect the 'request' not to use a PAT and not to use github_pat(). The call to github_pat() (instead of using NULL that was passed in) happens in 2 places.

The changes suggested cause auth_token=NULL to be used consistently, as if there were no PAT at all (which is what is being requested.

Since NULL is what github_pat() returns if there is no PAT stored, it seems like this does not break anything. It simply respects auth_token=NULL.

@gaborcsardi
Copy link
Member

Thanks! I am not entirely sure if that functions you changes are called from another code path or not. E.g. during update(pkg_deps()). If they are, this PR potentially breaks those usages if they rely on the auth token being filled in when NULL.

@gaborcsardi gaborcsardi merged commit 39a6a81 into r-lib:main Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants