Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoparquet update from CRAN #112

Open
gaborcsardi opened this issue Jan 31, 2025 · 2 comments
Open

nanoparquet update from CRAN #112

gaborcsardi opened this issue Jan 31, 2025 · 2 comments

Comments

@gaborcsardi
Copy link
Member

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_nanoparquet.html.

Please correct before 2025-02-13 to safely retain your package on CRAN.

Do remember to look at the 'Additional issues'.

The CRAN Team

* installing *source* package ‘nanoparquet’ ...
** package ‘nanoparquet’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C++ compiler: ‘Apple clang version 14.0.0 (clang-1400.0.29.202)’
using SDK: ‘MacOSX11.3.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -Ithrift -I. -Izstd/include  -I/opt/R/arm64/include   -DR_NO_REMAP -fPIC  -falign-functions=64 -Wall -g -O2   -c lib/ParquetReader.cpp -o lib/ParquetReader.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -Ithrift -I. -Izstd/include  -I/opt/R/arm64/include   -DR_NO_REMAP -fPIC  -falign-functions=64 -Wall -g -O2   -c RParquetReader.cpp -o RParquetReader.o
RParquetReader.cpp:1374:16: error: no member named 'pow' in namespace 'std'; did you mean simply 'pow'?
  double fct = std::pow(10.0, scale);
               ^~~~~~~~
               pow

> file_name <- system.file("extdata/userdata1.parquet", package = "nanoparquet")
> parquet_df <- nanoparquet::read_parquet(file_name)
lib/ParquetReader.cpp:881:23: runtime error: load of misaligned address 0x5609a5e9b98a for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment
0x5609a5e9b98a: note: pointer points here
 61 6e  64 61 06 00 00 00 41 6c  62 65 72 74 06 00 00 00  45 76 65 6c 79 6e 06 00  00 00 44 65 6e 69
              ^ 
    #0 0x7f36a579d614 in nanoparquet::ParquetReader::scan_byte_array_plain(nanoparquet::StringSet&, unsigned char*) /data/gannet/ripley/R/packages/tests-clang-UBSAN/nanoparquet/src/lib/ParquetReader.cpp:881:23
    #1 0x7f36a579b580 in nanoparquet::ParquetReader::read_dict_page(nanoparquet::ColumnChunk&, parquet::PageHeader&, unsigned char*, int) /data/gannet/ripley/R/packages/tests-clang-UBSAN/nanoparquet/src/lib/ParquetReader.cpp:449:5
    #2 0x7f36a5799879 in nanoparquet::ParquetReader::read_column_chunk_int(nanoparquet::ColumnChunk&) /data/gannet/ripley/R/packages/tests-clang-UBSAN/nanoparquet/src/lib/ParquetReader.cpp:248:5
    #3 0x7f36a57987bb in nanoparquet::ParquetReader::read_column(unsigned int) /data/gannet/ripley/R/packages/tests-clang-UBSAN/nanoparquet/src/lib/ParquetReader.cpp:218:5
    #4 0x7f36a57cc55c in RParquetReader::read_columns() /data/gannet/ripley/R/packages/tests-clang-UBSAN/nanoparquet/src/RParquetReader.cpp:223:7
> file_name <- system.file("extdata/userdata1.parquet", package = "nanoparquet")
> parquet_df <- nanoparquet::read_parquet(file_name)
lib/ParquetReader.cpp:881:23: runtime error: load of misaligned address 0x5250035fe90a for type 'uint32_t', which requires 4 byte alignment
0x5250035fe90a: note: pointer points here
 61 6e  64 61 06 00 00 00 41 6c  62 65 72 74 06 00 00 00  45 76 65 6c 79 6e 06 00  00 00 44 65 6e 69
              ^ 
    #0 0x7fc411b605c4 in nanoparquet::ParquetReader::scan_byte_array_plain(nanoparquet::StringSet&, unsigned char*) lib/ParquetReader.cpp:881
    #1 0x7fc411b7e222 in nanoparquet::ParquetReader::read_dict_page(nanoparquet::ColumnChunk&, parquet::PageHeader&, unsigned char*, int) lib/ParquetReader.cpp:449
    #2 0x7fc411b46e6d in nanoparquet::ParquetReader::read_column_chunk_int(nanoparquet::ColumnChunk&) lib/ParquetReader.cpp:248
    #3 0x7fc411b4bf92 in nanoparquet::ParquetReader::read_column(unsigned int) lib/ParquetReader.cpp:218
    #4 0x7fc411be79c0 in RParquetReader::read_columns() /data/gannet/ripley/R/packages/tests-gcc-SAN/nanoparquet/src/RParquetReader.cpp:223
@gaborcsardi gaborcsardi converted this from a draft issue Jan 31, 2025
@gaborcsardi
Copy link
Member Author

@gaborcsardi
Copy link
Member Author

CRAN macOS install fixed by #111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant