Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate env_vars for private variables #208

Closed
maelle opened this issue Mar 4, 2019 · 4 comments
Closed

separate env_vars for private variables #208

maelle opened this issue Mar 4, 2019 · 4 comments
Labels
rhub-package Issues related to the rhub package itself

Comments

@maelle
Copy link
Member

maelle commented Mar 4, 2019

if there were a separate check_args argument for private variables, there could be a separate field in the API response, and then one could include non private private variables in default printing methods.

@maelle maelle added the rhub-package Issues related to the rhub package itself label Mar 4, 2019
@gaborcsardi
Copy link
Collaborator

You mean env_vars?

@maelle
Copy link
Member Author

maelle commented Mar 5, 2019

oops yes

@gaborcsardi gaborcsardi changed the title separate checkArgs for private variables separate env_vars for private variables Mar 5, 2019
@gaborcsardi
Copy link
Collaborator

This is not only up to the R package, but the builders should know about it as well, e.g. not to list them in the logs. So this will be postponed until rhub-server is deployed.

@gaborcsardi
Copy link
Collaborator

This issue is about the previous R-hub system, it does not apply to the new system, so I am closing it now. Please see https://r-hub.github.io/rhub/ for the new system, R-hub v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rhub-package Issues related to the rhub package itself
Projects
None yet
Development

No branches or pull requests

2 participants