Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheQuint] CSV Content is not rendering on AMP pages #318

Open
SpandanaPatnam opened this issue Dec 21, 2020 · 9 comments
Open

[TheQuint] CSV Content is not rendering on AMP pages #318

SpandanaPatnam opened this issue Dec 21, 2020 · 9 comments

Comments

@SpandanaPatnam
Copy link

Zendesk ticket https://quintype.zendesk.com/agent/tickets/12307

Publisher URL : thequint.com
Client Type: Custom
CMS: thequint.quintype.com

Tested on other Instance : No

Issue: CSV Content is not rendering on AMP pages

They need help on AMP Pages to handle .csv content on FrontEnd.
Right now the CSV content is not rendering on AMP Pages for TQ.

Eg Link:- https://www.thequint.com/amp/story/tech-and-auto/bsnl-prepaid-recharge-plans-2020-list-of-all-packs-offers-combo

Screenshot of CSV content from API in story cards array

Tried https://developers.quintype.com/quintype-amp/module-Text.html from AMP DOCs
But I wasn't able to receive this through storyElement props.

Screenshot or Video

thequint

@ags1773
Copy link
Contributor

ags1773 commented Dec 22, 2020

CSV tables are currently not supported by AMP lib. This is a feature request which can be added to our roadmap

@SpandanaPatnam
Copy link
Author

Thanks @ags1773 We will let the client know about this, please let us know if there's an ETA on this to communicate to them

@ags1773
Copy link
Contributor

ags1773 commented Dec 23, 2020

@sramalin would be able to answer that

@SpandanaPatnam
Copy link
Author

@sramalin @ags1773 Client has come back on this as this feature is required, please let us know the ETA to share it with the client.

Client's response:

Hi team,

As a news publisher we make use of tables within our content while filing schedules which range from elections to key sports events like IPL to showcasing different plans for ISP providers. All this collectively helps bring traffic to the website.

As a News Publisher, The Quint is focusing towards AMP pages and the same has become our key source of traffic. Unavailability of tables on AMP pages affects us adversely.

Requesting your team to add a support for this.

cc: @sinimerlin @Sowbagya-lakshmi @Rachana-t

@sanju296
Copy link

sanju296 commented Jan 28, 2021

Devbox scenarios - 28 Jan 2021

  • Adding a CSV element to the story; An aXa matrix. Expected Result: The table should not overflow and break the layout.
  • Adding a CSV element to the story; An aXb matrix. Expected Result: The table should not overflow and break the layout.
  • Checking for other elements. Expected Result: The story page should not break with the table element and other elements.
  • Adding multiple table elements to the same story.
  • Adding an empty table with only header and no data

@sanju296
Copy link

sanju296 commented Jan 28, 2021

Staging scenarios:

  • AMP Cross Browser testing.
    • Chrome.
    • Firefox.
    • Safari
    • iOS Safari
    • iOS Chrome
  • Check for structured data. Expected Result: Should not throw any error.
  • Should not throw any amp error.

@sanju296
Copy link

sanju296 commented Jan 28, 2021

Definition of Done

  • All ACs are passing during the dev-box and in staging.
  • All Test cases are passing.
  • All High and medium bugs are closed.
  • Automate the test cases.

@sanju296
Copy link

sanju296 commented Jan 28, 2021

Issues:

@ags1773 ags1773 mentioned this issue Jan 28, 2021
9 tasks
@ags1773
Copy link
Contributor

ags1773 commented Jan 29, 2021

Platform dependancies:

  • limit the upload size of table element (it crashes the browser tabJavaScript heap out of memory if table size is in MBs)
  • don't set is-amp-supported:false in story API when there is a table element present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants