Datawrapper iframe

[CXAdi]

This Github issue is synchronized with Zendesk:

Ticket ID: #8957
Priority: normal
Group: Support
Requester: [email protected]
Organization: Vikatan
Assignee: Rachana TR
Issue escalated by: Rachana TR
Assigned Team: backend
Bug Related To: open_issue

Original ticket description:

Hi Team, adding below datawrapper iframe AMP is getting failed. Pls advise.

 

</script>

 

Regards,

Ismail Anees

[StInGDeaDlY]

@sramalin @Rachana-t Could you please add steps to reproduce?

[rashmirmittal]

@CXAdi Is this even Platform ticket? Or for the AMP team? HAve you guys done any analysis on this? There is no information in the ticket.

[sinimerlin]

@sramalin Please add in the details why this needs to be added from Platform

[sramalin]

@sinimerlin @Rachana-t @SpandanaPatnam @StInGDeaDlY @rashmirmittal
Please find my comments below

• When a ' Data wrapper ' is provided as a JS embed in a story, sketches mark this story with " is-amp-supported": false". This is an existing behavior and not sure the reason for the same. (Refer this BQ story

• BQ is using a custom AMP ignores platform's "is-amp-supported" flag and renders Data wrapper embedded strories,

• However AMP lib (Vikatan is the first publisher with AMP powered by AMP lib) is currently depending Platform's "is-amp-supported" flag .

@rashmirmittal @StInGDeaDlY @sharangj We have two options

1. Implement "is-amp-support" logic in AMP lib and continue enhancing it. We could fix this issue as part of this activity

2. Continue depending on Platform's flag and provide override options in AMP to skip this flag.

Thoughts?

[StInGDeaDlY]

Spoke to @sramalin . This will be handled in AMP library which in the future will not be looking at platform's is-amp-supported flag. Platform will be deprecating it going forward.

[StInGDeaDlY]

@sinimerlin
This ticket will be handled by AMP library team.

[sinimerlin]

Transferring issue to Amp-library

[sinimerlin]

@sramalin Please provide an update on this

[SpandanaPatnam]

@sramalin Please help us with an update on this

[sramalin]

@SpandanaPatnam We are going with Option 1. This is already planned for this quarter (July - Sep)