Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: print_version_info() doesn't work outside of ria directory #23

Open
mrl280 opened this issue Mar 15, 2024 · 1 comment
Open

BUG: print_version_info() doesn't work outside of ria directory #23

mrl280 opened this issue Mar 15, 2024 · 1 comment
Labels
bug 🐞 There is a problem, error, or unexpected behaviour

Comments

@mrl280
Copy link
Collaborator

mrl280 commented Mar 15, 2024

Description:
print_version_info() only works if your current working directory is the 'ria' directory.
If you are in a different git project, it will report the git hash of that project.
If you are not in a git project, the helper function _get_commit_hash() will raise a RunTimeError.

Project Area:
ria.diagnostics.print_version_info.py

Steps to Reproduce:
Run ria version from the command line outside the ria project directory, or ria.print_version_info() from within a Python environment.

Expected Behavior:
Report the git hash of the installed version of ria.

Actual Behavior:
Report the git hash of the current working directory, If you are in the 'ria' directory, it works as expected, but otherwise it scrapes the wrong hash. Raises a RunTimeError if you are not in a git directory.

@mrl280
Copy link
Collaborator Author

mrl280 commented Mar 19, 2024

I removed the broken implementation in fdb097d. Additional work is needed to develop a new implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 There is a problem, error, or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants