This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Disable JIT compiler on unsupported platforms #21215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2021
|
Thanks! |
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2021
(cherry picked from commit b4d0938)
mergify bot
added a commit
that referenced
this pull request
Nov 9, 2021
(cherry picked from commit b4d0938) Co-authored-by: Kirill Fomichev <[email protected]>
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
)" This reverts commit 4c66126.
jennnx
added a commit
to jennnx/buildspace-projects
that referenced
this pull request
Sep 15, 2022
Hey! I posted in Discord about this, and wanted to suggest a PR too. There's basically two things: 1) `anchor test` now runs out of the box. The developers there fixed this issue in solana-labs/solana#21215, where they automatically disabled `bpf-jit` in validators for m1s and windows. I tried to update that everywhere it was referenced. 2) I think the section on `solana-keygen -o` and outputting it to the `target/deploy` folder *might* be outdated. Maybe it was M1-specific, but following along with the main tutorial (the one for Linux/x86) where you just use `solana-keygen new` and use your default created wallet was way easier. In fact, since the `Anchor.toml` file generated by `anchor init` by default expects the wallet to be at `"/Users/x/.config/solana/id.json"`, it was giving me some errors before I did the switch. Maybe it's better to just delete this setup-flow completely and make everyone use the main tutorial on the buildspace website! The only "broken" thing for the M1 side is just the actual installation of anchor itself (the main tutorial on buildspace pulls the CLI binary directly from anchor's github, but as per the docs m1 processors should use avm instead).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now only
solana-test-validatorchecks JIT support and only for Windows, not for arch (x86_64 / arm). Developers need to pass--no-bpf-jitexplicitly and sometimes this is hard because test validator is launched by other tools (for example anchor: coral-xyz/anchor#876).Summary of Changes
Issues which will change conditional compilation when will be resolved: qmonnet/rbpf#48 solana-labs/rbpf#217