Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #24

Closed
qmonnet opened this issue Sep 4, 2017 · 3 comments
Closed

Update README.md #24

qmonnet opened this issue Sep 4, 2017 · 3 comments

Comments

@qmonnet
Copy link
Owner

qmonnet commented Sep 4, 2017

The README.md file is somewhat outdated. In particular:

  • It should mention the systems rbpf can be compiled on (Linux/MacOS, Windows as well but without the JIT (see Make JIT usable on Windows #21)).
  • It does not mention the API created some time ago to build the BPF programs.
  • There are probably a lot of other items to update.

If you stumble on something else, do not hesitate to add elements to update below, so that I do not forget them the day I dive into this!

@jackcmay
Copy link
Collaborator

(let me know if I should ask this question someplace other than this issue)

What API to build BPF programs are you referring to?

@qmonnet
Copy link
Owner Author

qmonnet commented Sep 26, 2018

No problem :)

That would be this one.

@qmonnet
Copy link
Owner Author

qmonnet commented Oct 10, 2018

Well maybe there is not that much to change after all. I pushed a couple of commit in that direction:

And I believe we're mostly good. I ran the tests and they still pass (I just pushed one fix). Another update will be needed when we merge the PR for returning errors from the verifier, but I pushed the change to the related branch already... So let's close here. Everyone, feel free to reopen if you spot other things to change or update on the README.

@qmonnet qmonnet closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants