Support newer versions of protobuf #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes build with a more recent version of the protobuf library (24.4) by replacing old function calls with their Abseil (20230125) equivalents.
|
I'm happy, but the workflows are not. |
|
Sorry, sick, sick kids, non-fun times. |
|
I'll investigate now that the workflow has been run, hopefully it'll automatically re-run when I push to the branch. Based on the output fingers crossed that I'm just missing |
|
It's been on my list to do, but the open This does not pass SBCL or CCL, I don't care about ABCL atm. |
|
Closing since it looks like the build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library doesn't compile with newer versions of protobuf (see #402), because some functions have been moved/renamed.
After I completed this patch, I realized that this duplicates efforts that already exist:
But this is all tidy and in a smaller and more manageable diff. Ultimately because this is a Google library you might opt to close this PR and merge those others instead :)
fixes #402