QMS plugin crashes in master

[pigreco]

What is the bug or the crash?

in the master update now, starting the QMS plugin, QGIS crashes

## Report Details

**Python Stack Trace**

Windows fatal exception: access violation

Current thread 0x000064c0 (most recent call first):
  File "C:\Users/pigre/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\quick_map_services\qgis_map_helpers.py", line 174 in add_layer_to_map
    layer.setAttribution(ds.copyright_text)
  File "C:\Users/pigre/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\quick_map_services\quick_map_services.py", line 199 in insert_layer
    add_layer_to_map(ds)


**Stack Trace**
No stack trace is available.


**QGIS Info**
QGIS Version: 3.41.0-Master
QGIS code revision: 9e25ade872
Compiled against Qt: 5.15.13
Running against Qt: 5.15.13
Compiled against GDAL: 3.11.0dev-6074ce4975
Running against GDAL: 3.11.0dev-6074ce4975



**System Info**
CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.22631

Steps to reproduce the issue

1. start the master
2. load the OSM background map using the QMS plugin

Versions

Versione di QGIS	3.41.0-Master
Revisione codice QGIS	9e25ade872
Librerie
Versione Qt	5.15.13
Versione Python	3.12.8
Versione GDAL/OGR	3.11.0dev-6074ce4975
Versione PROJ	9.5.1
Versione database del Registro EPSG	v11.022 (2024-11-05)
Versione GEOS	3.13.0-CAPI-1.19.0
Versione SQLite	3.46.1
Versione PDAL	2.8.3
Versione client PostgreSQL	unknown
Versione SpatiaLite	5.1.0
Versione QWT	6.3.0
Versione QScintilla2	2.14.1
Versione SO	Windows 11 Version 2009
Questa copia di QGIS scrive messaggi di debug.
Plugins Python attivi
DataPlotly	4.2.0
filtra_selecionados	1.2
gensimplot	2.1
gimpselectionfeature_plugin	1.6
GroupStats	2.2.7
latlontools	3.7.2
nominatim_locator_filter	0.3.2
pointsamplingtool	0.5.4
profile-manager	0.31
qconsolidate	1.1.0
qduckdb	1.2.1
qgis_plugin_gpq_downloader	0.3.4
QuickOSM	2.3.2
quick_map_services	0.19.37
Split-Lines-By-Points-main	1.0
ViewshedAnalysis	1.9.1
db_manager	0.1.20
MetaSearch	0.3.6
processing	2.12.99

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

No response

[rouault]

That should be reported to the authors of the plugin at https://github.com/nextgis/quickmapservices so they investigate if that's a misuse of the QGIS API from their side or really a QGIS issue

[agiudiceandrea]

The crash occurs on Windows 10 running the latest QGIS 3.41.0-Master 9e25ade (Jan 25, 2025) and f33604b (Jan 23, 2025) from OSGeo4W (using Python 3.12.8 and python3-sip 6.9.1) with the latest plugin version 0.19.37 and also with previous ones (0.19.36, 0.19.35, 0.19.34).

The crash doesn't occur on the same system running QGIS 3.41.0-Master f999386 (Jan 12, 2025) from OSGeo4W (using Python 3.12.8 and python3-sip 6.8.3) either with the latest plugin version or with the previous ones.

@rouault, the following simple -supposedly legit- Python code executed in the Python console makes QGIS 3.41.0-Master 9e25ade crash:

layer = QgsVectorLayer("Point?field=fldtxt:string&field=fldint:integer", "testlayer", "memory")
layer.setAttribution("test")

There is a test in place

QGIS/tests/src/python/test_qgsvectorlayer.py

Line 3779 in 6ca5140

layer.setAttribution("MyAttribution")

Maybe it's a Windows \ OSGeo4W specific issue.

[agiudiceandrea]

Maybe it's a Windows \ OSGeo4W specific issue.

It looks like an OSGeo4W specific issue: the crash doesn't occur on the same system running a MingW64 build (using Python 3.11.10, sip 6.7.10) at the same commit.

Ping @jef-n.

[nyalldawson]

May be because setAttribution is deprecated, so could be fallout from #59834

It would be interesting to see if other deprecated methods cause crashes on that build.

[agiudiceandrea]

It would be interesting to see if other deprecated methods cause crashes on that build.

@nyalldawson, it looks like the crash occurs with deprecated methods of QgsMapLayer involving QGIS Server (abstract, setAbstract, attribution, setAttribution, ...) while it doesn't occur with deprecated methods like hasAutoRefreshEnabled and setAutoRefreshEnabled.
The crash also occurs with other deprecated methods in other classes, e.g. QgsProject().fileInfo().

[nyalldawson]

ok, let's see if @troopa81 has any insights...

[troopa81]

Ouch... I'm gonna build a Windows dev env and try to reproduce ...

[jef-n]

iface.activeLayer().attribution() crashes too. Using serverProperties() helps

174             if hasattr(layer, 'serverProperties'):
175                 layer.serverProperties().setAttribution(ds.copyright_text)
176                 layer.serverProperties().setAttributionUrl(ds.copyright_link)
177             else:
178                 layer.setAttribution(ds.copyright_text)
179                 layer.setAttributionUrl(ds.copyright_link)

[agiudiceandrea]

@jef-n, indeed the crash occurs with various methods of QgsMapLayer e.g. abstract, setAbstract, attribution, setAttribution, shortName, setShortName ... but not with e.g. hasAutoRefreshEnabled and setAutoRefreshEnabled, and also occurs e.g. with QgsProject().fileInfo().
The crash didn't occur running QGIS 3.41.0-Master f999386 (Jan 12, 2025 - Python 3.12.8, python3-sip 6.8.3) and previous versions.
The crash occurs using QGIS 3.41.0-Master f33604b (Jan 23, 2025 - Python 3.12.8, python3-sip 6.9.1), 9e25ade (Jan 25, 2025 - Python 3.12.8, python3-sip 6.9.1) and subsequent versions, while it doesn't occur running a MingW64 build (https://github.com/qgis/QGIS/actions/runs/12963618546) at the same commit 9e25ade (Python 3.11.10, sip 6.7.10).

[jef-n]

also happens on debian

gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
#1  0x00007fffe509ddef in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
#2  0x00007fffe5049d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007fffe50324f0 in __GI_abort () at ./stdlib/abort.c:79
#4  0x00007fffe503332d in __libc_message_impl (fmt=fmt@entry=0x7fffe51b517a "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:132
#5  0x00007fffe51263f5 in __GI___fortify_fail (msg=msg@entry=0x7fffe51b5192 "stack smashing detected") at ./debug/fortify_fail.c:24
#6  0x00007fffe51275e0 in __stack_chk_fail () at ./debug/stack_chk_fail.c:24
#7  0x00007fff9003b0f4 in sip_api_deprecated_12_16 () at /usr/lib/python3/dist-packages/PyQt5/sip.cpython-313-x86_64-linux-gnu.so
#8  0x00007ffeea3b185f in meth_QgsProject_fileInfo (sipSelf=<QgsProject at remote 0x7ffee7533530>, sipArgs=()) at ./debian/build/python/core/build/_core/sip_corepart9.cpp:49951

[agiudiceandrea]

The crash doesn't occur on Ubuntu 22.04.1 running QGIS 3.41.0-Master 6f4df5d (Jan 2, 2025, from https://ubuntu.qgis.org/ubuntu-nightly/).

[troopa81]

@agiudiceandrea @jef-n Thank you for the report. I'm suspecting that pyqt-sip module is not build against the same sip build than the qgis package. Because in the @jef-n stacktrace we see that it crashes when calling sip_api_precated_12_16, and I presume the symbol is missing.

I'm rebuilding to test a little bit more thoroughly, but I think I'm gonna disable the deprecated support until I figured out what the issue reaaly is