Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Field calc] recent group does not clear expression area #33131

Closed
pigreco opened this issue Nov 28, 2019 · 5 comments
Closed

[Field calc] recent group does not clear expression area #33131

pigreco opened this issue Nov 28, 2019 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers GUI/UX Related to QGIS application GUI or User Experience

Comments

@pigreco
Copy link
Contributor

pigreco commented Nov 28, 2019

If there is a function or expression in the expression area, the use of the recent group does not erase the previous expressions, but appends them.

Is it a correct behavior?

gr_recenti

OSGeo4W64b - win 10 - QGIS 3.10

@pigreco pigreco added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Nov 28, 2019
@gioman gioman added the GUI/UX Related to QGIS application GUI or User Experience label Nov 28, 2019
@gioman
Copy link
Contributor

gioman commented Nov 28, 2019

Arguably not a bug.

@elpaso
Copy link
Contributor

elpaso commented Nov 29, 2019

Bug or not bug I don't care but this worth a deeper discussion.

For functions, variables and operators the current behavior is just fine, but I think that it is not the best UX for recent expressions: when selecting a Recent expression this is 100% of the times a complete expression that you have used as is in the past, it does not make much sense to insert it at the cursor position without clearing the input box (unless it's already empty of course).

On the other hand, having two different behaviors might be confusing for the users, even if the recent expressions are at the bottom of the groups and are really something on their own.

I see three possibilities here:

  1. to implement an opt-in clear-before-paste behavior for recent expressions: the first time a recent expression is inserted a confirm dialog with a "[x] don't ask me again" will ask the user if she want to clear the input box before inserting recent expressions.
  2. to add a broom icon to the toolbar to ease clearing the input box
  3. do nothing :)

@Pedro-Murteira
Copy link

This is still an issue on QGIS 3.16.15 and 3.22.2. This issue should in my opinion be labeled as a Feature Request, and the possibilities mentioned by @elpaso should be considered.

@alexbruy
Copy link
Contributor

As expression dialog now has a button to clear the input box we probably can close this.

@alexbruy alexbruy added the Feedback Waiting on the submitter for answers label Jan 29, 2025
@pigreco
Copy link
Contributor Author

pigreco commented Jan 29, 2025

given the various comments, for me the issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

No branches or pull requests

5 participants