[ONNX] Update API to torch.onnx.export(..., dynamo=True) #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3220
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
reviewed
Jan 8, 2025
| @@ -7,7 +7,8 @@ | |||
| ==================== | |||
|
|
|||
| Authors: | |||
| `Thiago Crepaldi <https://github.com/thiagocrepaldi>`_, | |||
| `Ti-Tai Wang <https://github.com/titaiwangms>`_, `Justin Chu <https://github.com/justinchuby>`_, | |||
There was a problem hiding this comment.
Is there any particular reason to remove the original author?
There was a problem hiding this comment.
He does not work in our team anymore.
svekars
reviewed
Jan 8, 2025
| @@ -7,12 +7,12 @@ | |||
| Export a PyTorch model to ONNX | |||
| ============================== | |||
|
|
|||
| **Author**: `Thiago Crepaldi <https://github.com/thiagocrepaldi>`_ | |||
| **Author**: `Ti-Tai Wang <https://github.com/titaiwangms>`_ | |||
There was a problem hiding this comment.
We typically don't remove the original author even if they left the project. POC for reviews/updates are managed through this issue and labels.
|
OK I will redo another version that merges into 2.6 and not deleting on previous author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
Description
Checklist
cc @xadupre @justinchuby