Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue#2168 #3181

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fixing issue#2168 #3181

merged 2 commits into from
Dec 11, 2024

Conversation

DeeExe
Copy link
Contributor

@DeeExe DeeExe commented Dec 11, 2024

Fixes #ISSUE_NUMBER

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @albanD @jbschlosser

Copy link

pytorch-bot bot commented Dec 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3181

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @DeeExe!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars svekars added the core Tutorials of any level of difficulty related to the core pytorch functionality label Dec 11, 2024
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svekars svekars merged commit 7038ce7 into pytorch:main Dec 11, 2024
1 check passed
@asideofcode-dev
Copy link

asideofcode-dev commented Jan 8, 2025

@svekars @DeeExe @albanD I'm confused, why is that pre-factor needed ?

@asideofcode-dev
Copy link

asideofcode-dev commented Jan 8, 2025

@svekars @DeeExe @albanD I dug into this further and concluded that this change was not necessary after-all. The m prefactor is not necessary. To avoid duplication I shared the reasoning in a comment over on the original issue #2168 (comment)

I've also created a PR to revert the change #3221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants