Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that master branch is not used in the CI #97

Open
datapythonista opened this issue Aug 5, 2019 · 2 comments
Open

Validate that master branch is not used in the CI #97

datapythonista opened this issue Aug 5, 2019 · 2 comments

Comments

@datapythonista
Copy link
Member

One "mistake" that most people did in their first PR was to make the changes in the master branch. This shouldn't be done, because the local repository gets into a state that no branches for new features can be created.

In #32 we'll soon have a CI system implemented. Can we have a check in the CI that fails when a PR is opened from the master branch?
@Aya-S
Copy link
Contributor

Aya-S commented Aug 5, 2019

@bhavaniravi any recommendations on how I can work on this as a buildup on your work for #32

@bhavaniravi
Copy link
Contributor

Sure @Aya-S I am almost done. Will give a PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Aya-S @datapythonista @bhavaniravi