-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement header in Sphinx #83
Comments
For a bit of extra information... In pandas the standard is to assume in all docs that pandas and numpy are already imported (as Since every file in the docs had those imports, and few things more, we ended up standardizing it in a variable, so when something changes, it changes everywhere. |
@galuhsahid can you provide some more details about this issue and may be an entry point to tackle this? |
@Aya-S Sure! When I tried to build the docs I saw these undefined I think a good entry point would be to replicate what pandas is doing and see if it works, then if it does maybe we can iterate from there should we want to change something. The content of the header variable in pandas can be found here--it's a bunch of import statements and the reason why they're there, I'm guessing, is what @datapythonista said. Seems like we also need to set these up too: |
Is anyone working on this? If not, I can give it a go. |
I guess no one is, I'll take it then. |
@MKhalusova I was planning to work on it but fell ill and am still recovering. you can go ahead and attempt this. |
Why do docs need to import pandas and numpy? |
Not the right person to answer that, since I think it's a very bad idea, and I'm strongly against doing that. But some people in the core dev team want to avoid having an |
@datapythonista Sorry, that's not what I meant. Let me rephrase. Generated documentation is in HTML, so what purpose does an added import serve in an html file? |
Ah, I understand now, good point. I don't think in the contributing documentation there is much code, but in the user guide for example there are lots of ipython block codes that sphinx runs to show the output in the html pages. |
I've had some circumstances that prevent me from completing this. Someone else can take over. |
I could give it a try if this is still relevant. |
I proposed yesterday to remove it from pandas (pandas-dev/pandas#28038), but I'd say it's a good learning exercise, and relevant in the short term. |
As discussed in #51, we need a separate PR to implement
header
. I think we probably need to determine what the value should be, though, whether we should stick to panda's implementation or not (& if not what the value ofheader
should be).The text was updated successfully, but these errors were encountered: