You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In pandas we have a header variable that we inject at the top of all documentation pages. One of the things there is randn = np.random.randn, which is a very bad idea that is only useful to confuse users.
With a quick grep I could just find a single case where that is used:
whatsnew/v0.10.0.rst: In [58]: p4d = Panel4D(randn(2, 2, 5, 4),
We should replace that case to use np.randon.randn explicitly, remove that line from the header in doc/source/conf.py and see in the doc builds if nothing fails after that change (this can be done locally or also in the CI).
The text was updated successfully, but these errors were encountered:
Hi @marc.
Is this for testing?
I can infer that the issue is with using 'randn' as variable name not change np.random.randn to np.randon.randn.
Please clarify, I will send PR for this
that's code that shows in the docs, I don't think in that specific case the code is even run by Sphinx, since that Panel4D class doesn't exist anymore.
The issue is that randn = np.random.randn is a very bad idea, and we'll make that code public now (we run it in the docs, but we don't show it now).
See the discussion here: pandas-dev/pandas#28038 (comment)
In pandas we have a
header
variable that we inject at the top of all documentation pages. One of the things there israndn = np.random.randn
, which is a very bad idea that is only useful to confuse users.With a quick grep I could just find a single case where that is used:
We should replace that case to use
np.randon.randn
explicitly, remove that line from the header indoc/source/conf.py
and see in the doc builds if nothing fails after that change (this can be done locally or also in the CI).The text was updated successfully, but these errors were encountered: