Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JavaScript dependency eslint to 9 #17444

Open
miketheman opened this issue Jan 17, 2025 · 5 comments · May be fixed by #17449
Open

Upgrade JavaScript dependency eslint to 9 #17444

miketheman opened this issue Jan 17, 2025 · 5 comments · May be fixed by #17449
Labels
dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs good first issue This issue is ideal for first-time contributors! javascript requires change to JavaScript files

Comments

@miketheman
Copy link
Member

The current version of eslint 8 uses the eslintConfig from package.json and is incompatible with eslint 9.

Read, then follow relevant steps of the migration guide - some may not be simple 1-to-1 steps.

The overall outcome is:

  • package.json is updated for the right eslint version
  • package.json no longer has any eslint directives in it
  • package-lock.json only contains only the necessary updates
  • an new config file has the config directives
  • all lints and tests pass

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide.

If you are working on this issue and have questions, feel free to ask them here, in the PyPA Discord or on the Discourse.

@miketheman miketheman added dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs good first issue This issue is ideal for first-time contributors! javascript requires change to JavaScript files labels Jan 17, 2025
@D3athSkulll
Copy link

Hey , I am willing to work on this issue, can you please allocate it to me?

@miketheman
Copy link
Member Author

Hey , I am willing to work on this issue, can you please allocate it to me?

Feel free to submit a PR, we do not routinely assign issues to non-members.

@D3athSkulll
Copy link

Hey I have submitted a PR, can you pls verify it.

@D3athSkulll
Copy link

Hey ,can you please verify my submitted pr?

@miketheman
Copy link
Member Author

Hi @D3athSkulll , I reviewed the PR, and added a bunch of notes.
Please consider that not everyone is working as the same time as you, and we all have different response times and commitments.

@miketheman miketheman linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs good first issue This issue is ideal for first-time contributors! javascript requires change to JavaScript files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants