Always set rpath to point at the .libs directory

[ender-wieczorek]

When grafting a library, it's dependencies are either:

• available on the system (as specified in the policy)
• also grafted into the wheel.

So, we should always set the rpath of the grafted library to point at the .libs directory.

Currently (see

auditwheel/src/auditwheel/repair.py

Line 155 in 9b0de8d

patcher.set_rpath(dest_path, dest_dir)

):

• we only set the rpath if the library already has rpath or runpath set
• set the rpath to a relative path. Note that relative paths are interpreted by the dynamic linker as relative to the current working directory, not relative to the library. To use a path relative to the library, we need $ORIGIN.

So, the patch I'm proposing is:

--- repair.py	2021-10-23 04:36:19.144441648 +0000
+++ repair.py	2021-10-23 04:36:38.860464792 +0000
@@ -151,8 +151,7 @@
 
     patcher.set_soname(dest_path, new_soname)
 
-    if any(itertools.chain(rpaths["rpaths"], rpaths["runpaths"])):
-        patcher.set_rpath(dest_path, dest_dir)
+    patcher.set_rpath(dest_path, "$ORIGIN")
 
     return new_soname, dest_path