Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing numba dispatch for gammainc_grad #1149

Open
aseyboldt opened this issue Jan 8, 2025 · 2 comments
Open

Missing numba dispatch for gammainc_grad #1149

aseyboldt opened this issue Jan 8, 2025 · 2 comments

Comments

@aseyboldt
Copy link
Member

Description

There still seems to be an issue with the gradient of gammainc in numba mode:

import pytensor
import pytensor.tensor as pt

x = pt.vector("x")
y = pt.math.gammainc(x, x)
dx = pytensor.grad(y.sum(), x)
func = pytensor.function([x], dx, mode="NUMBA")
func([1.])

This raises warnings about object mode for gammainc_grad_a and gammainc_grad_b. Those look like ScalarLoop Ops, and I thought we added those recently? Maybe something in the specific ops is raising an error?

original report in nutpie:
pymc-devs/nutpie#163 (comment)

@ricardoV94
Copy link
Member

No ScalarLoop is still missing a numba impl, we just fix it failing to even get to obj mode

@ricardoV94
Copy link
Member

#299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants