Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8 support #339

Closed
manulera opened this issue Jan 23, 2025 · 3 comments
Closed

Drop python 3.8 support #339

manulera opened this issue Jan 23, 2025 · 3 comments
Assignees

Comments

@manulera
Copy link
Collaborator

Biopython has dropped python 3.8 support in their last release, so we won't be able to use the latest version until we drop it as well.

I would say this is probably fair in 2025, let me know what you think. In the mean time, I will see if I can fix #337

@manulera
Copy link
Collaborator Author

I am thinking we could also pin a particular biopython version rather than >= something. In the end we depend so much on their methods that if anything changes (clearly it does) it may be problematic.

@BjornFJohansson
Copy link
Collaborator

i agree to drop 3.8 and also to pin the biopython versions with more granularity.
Pydna is especially sensitive to changes in the Bio.Seq module.
They changed the Bio.Seq data property to bytestring between 1.78 and 1.79,
so biopython = ">=1.80,<=1.85" should work.
I don't remember right now if 1.79 also works.

BjornFJohansson pushed a commit that referenced this issue Jan 25, 2025
@manulera
Copy link
Collaborator Author

This is already done in #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants