Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pupil Dilated and Patient Eye Movement error when empty, even when they are allowed to be empty #147

Closed
qarmin opened this issue Dec 16, 2024 · 5 comments · Fixed by #149
Closed

Pupil Dilated and Patient Eye Movement error when empty, even when they are allowed to be empty #147

qarmin opened this issue Dec 16, 2024 · 5 comments · Fixed by #149
Labels
bug

Comments

@qarmin
Copy link

qarmin commented Dec 16, 2024 

Tag (0022,0005) (Patient Eye Movement Commanded) value is not allowed  (value: , allowed: YES, NO)
Tag (0022,000D) (Pupil Dilated) value is not allowed  (value: , allowed: YES, NO)

https://dicom.innolitics.com/ciods/ophthalmic-photography-8-bit-image/ophthalmic-photography-acquisition-parameters/00220005

https://dicom.innolitics.com/ciods/ophthalmic-photography-8-bit-image/ophthalmic-photography-acquisition-parameters/0022000c
@mrbean-bremen
Copy link
Member

Thanks, I will have a look! Looks like type 2 tags are not handled in the enum check.

mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Dec 16, 2024
@mrbean-bremen
Fix check for empty string values
febc6d9 
- broke handling of empty type 2 enumerated values
- fixes pydicom#147
@mrbean-bremen mrbean-bremen mentioned this issue Dec 16, 2024
Merged
mrbean-bremen added a commit that referenced this issue Dec 16, 2024
@mrbean-bremen
Fix check for empty string values
5d3ceec 
- broke handling of empty type 2 enumerated values
- fixes #147
@mrbean-bremen
Copy link
Member

@qarmin - should be fixed in main, please check! If you confirm, I'll make a patch release with the fix.

@qarmin
Copy link
Author

qarmin commented Dec 19, 2024

I tested it and looks that patch works, thanks

@mrbean-bremen
Copy link
Member

Thanks, I will make a patch release tonight then.

@mrbean-bremen
Copy link
Member

Ok, the release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix check for empty string values mrbean-bremen/dicom-validator
2 participants
@mrbean-bremen @qarmin