-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration and parameters for all_messages()
and new_messages()
#496
Comments
I'm fine to add these parameters, but I do want to point out that current |
@samuelcolvin So right now if Agents A and B have their own system prompts and dynamic system prompts, and we pass the history from A to B, B would take A's system prompt + whatever was dynamically added in it and ignore its own system prompt and won't even bother calling the dynamic system tool right? |
Hey @samuelcolvin, I want to link to #531 Hamza and I discussed Today. |
Hi @josead, yes please create a PR. |
It would be helpful if the
all_messages()
andnew_messages()
methods had an option to exclude the system prompt likeall_messages(system_prompt=False)
. This would probably be a better default behavior too. Why?Well, when do you use these methods?
1. Passing messages to the client/frontend
You probably don't want to pass the system prompt along.
2. When storing messages in a database
You probably don't want to store the system prompt for every conversation.
3. When handing over a conversation to a different agent
You want the chat messages for context, but the system prompt of the new agent.
More parameters to exclude tool calls or just tool call responses would be another great addition, I think.
The text was updated successfully, but these errors were encountered: