Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

background_color manifest setting not respected #295

Open
comp615 opened this issue Mar 8, 2018 · 4 comments
Open

background_color manifest setting not respected #295

comp615 opened this issue Mar 8, 2018 · 4 comments

Comments

@comp615
Copy link

comp615 commented Mar 8, 2018

Running
yarn pwabuilder -- https://mobile.twitter.com -l debug -p windows10

the output manifest.json has
"background_color": "transparent"

However, at https://mobile.twitter.com/manifest.json you can see that it has
"background_color":"#ffffff"

I'd expect that user specification to be maintained when supplied (since I think it's used to generate the windows 10 splash background)

@boyofgreen
Copy link
Contributor

I'll look into this. It should be maintained for sure.

@boyofgreen
Copy link
Contributor

I think i found the issue, and should be pretty easy to change. In the meantime, if you would like a work around, you can find the file in this dir: PWA\Store packages\windows10\manifest called "appxmanifest.xml" and edit this value <uap:VisualElements BackgroundColor="" /> it will change it. This will fix it for sideloading and appx generation. I should have this code reviewed and out in a few days.

@comp615
Copy link
Author

comp615 commented Mar 9, 2018

I think you probably want it as background color on uap:SplashScreen right? Although VisualElements can work too, that's for icons and tiles so might not be as direct a translation

@boyofgreen
Copy link
Contributor

So if you put it on the VisualElements tag then it will effect the tile and splash screen both, unless you also define splash screen background color then it will override what is in Visual Elements. So if you only want to alter the splashscreen color then yes. Thanks for the clarification.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants