Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Result Metrisch Einheit #1293

Closed
4 tasks done
peggimann opened this issue Jan 13, 2025 · 4 comments · Fixed by #1322
Closed
4 tasks done

Key Result Metrisch Einheit #1293

peggimann opened this issue Jan 13, 2025 · 4 comments · Fixed by #1322
Assignees
Labels
bug Something isn't working

Comments

@peggimann
Copy link
Collaborator

peggimann commented Jan 13, 2025

Als User möchte ich folgende Aktionen für Metrische Einheiten

  • Erstellen
  • Löschen
  • Bearbeiten

Zusätzlich möchte ich nicht mehr ein Select für die Einheiten sondern ein Textfeld mit auto-completion

Anforderungen

Akzeptanzkriterien

  • Beim Löschen und Bearbeiten einer Einheit werden Berechtigungen beachtet (Nur Ersteller darf dies)
  • Das Feature ist getestet (E2E und Unit-Tests)
  • Die Namingconventions wurden eingehalten.
  • Alle Anforderungen sind erfüllt
@MasterEvarior MasterEvarior added the bug Something isn't working label Jan 16, 2025
@kcinay055679 kcinay055679 linked a pull request Jan 21, 2025 that will close this issue
@kcinay055679
Copy link
Collaborator

I refactored the way units are stored, then i created the neccesery services to create a post endpoint.
I wrote a simple IT to ensure it's behavior.

TODO:

  • Write endpoints for (c)rud
  • tests for backend
  • frontend

@kcinay055679 kcinay055679 self-assigned this Jan 22, 2025
@kcinay055679
Copy link
Collaborator

kcinay055679 commented Jan 23, 2025

finished CRUD implementation

TODO

  • Write tests for UnitPersistenceSerivce and `UnitValidationService
  • frontend`

@kcinay055679
Copy link
Collaborator

kcinay055679 commented Jan 28, 2025

The Actionplan is fully generified in #1342 but the tests have to be fixed. look in pr for more Info.
The PR #1322 has all the requested features implemented afaik, a few tests are failing complete testing (junit, cypress)
#1342 is a feature branch from main. #1322 is a feature branch from #1342, so whenever you want to change something on the behavior of the actionplan do this on #1342 and then rebase #1322 to avoid messy pr's
TODO

  • Fix styling according to Figma
  • Fix and extend tests

@RandomTannenbaum
Copy link
Collaborator

RandomTannenbaum commented Jan 31, 2025

ToDo

  • Make "Create new" clickable with the Enter-button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants