Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM publishing race condition between main and release workflows #284

Closed
flostadler opened this issue Dec 6, 2024 · 1 comment · Fixed by #315
Closed

NPM publishing race condition between main and release workflows #284

flostadler opened this issue Dec 6, 2024 · 1 comment · Fixed by #315
Assignees
@corymhall
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.115

Comments

@flostadler
Copy link
Contributor

In #282 the release was triggered while the main workflow was running so by the time the main workflow hit the dev release the new tag existed and it published a v1.2.0 version with a dev tag. Then the release workflow tried to publish v1.2.0 with latest tag and failed.
@flostadler flostadler added the kind/engineering Work that is not visible to an external user label Dec 6, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 6, 2024
@flostadler flostadler removed the needs-triage Needs attention from the triage team label Dec 6, 2024
@flostadler flostadler added this to the 0.115 milestone Dec 6, 2024
@corymhall corymhall mentioned this issue Dec 24, 2024
Closed
corymhall added a commit that referenced this issue Dec 24, 2024
@corymhall
chore: add concurrency group to release job
fedebd3 
This adds a concurrency group to the release workflow so only 1 release
will occur at a time

fixes #284
@corymhall corymhall mentioned this issue Dec 24, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 24, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #315 and shipped in release v1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.115
Development

Successfully merging a pull request may close this issue.

chore: add concurrency group to release job pulumi/pulumi-cdk
3 participants
@flostadler @pulumi-bot @corymhall