Handle pulumi.Output recursively when translating CDK properties to Pulumi #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Nov 18, 2024
t0yv0
commented
Nov 18, 2024
t0yv0
commented
Nov 18, 2024
| if (Array.isArray(value)) { | ||
| const result: any[] = []; | ||
| for (let i = 0; i < value.length; i++) { | ||
| result[i] = normalize(value[i], cfnType); | ||
| result[i] = normalize(value[i], cfnType, pulumiProvider); |
There was a problem hiding this comment.
Should keep recurring with provider set, right? Sounds like a slightly unrelated bug fix.
t0yv0
changed the title
|
Iterating on the integration failure, it is rather interesting. |
t0yv0
force-pushed
the
t0yv0/normalize-outputs-bug
branch
from
9e27f4f to
077d267
Compare
corymhall
approved these changes
Nov 19, 2024
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulumi.Outputvalues seem to be able to reach thenormalizestep of translating properties from a CDK notation to a Pulumi notation and making sure the casing is right. This may be happening in particular because CF intrinsic evaluator may emit Output values. With the fix, thenormalizestep can deeply recur into these eventual values and make sure that the property casing is correctly handled regardless of whether a value is an eventual or not.This seems to resolve an issue I have been running into when testing a Kinesis Stream.