Fix CDK errors not being logged #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason trying to log an error using `error` does not log anything. Also, we were not throwing the error so we were continuing until it failed later with a different very unhelpful error message. Instead of logging (since it doesn't work) just throw the error
Closed
t0yv0
reviewed
Nov 12, 2024
| @@ -152,15 +151,13 @@ export class App | |||
| const message = e.message as string; | |||
| const messageParts = message.split('Context lookups have been disabled. '); | |||
| const missingParts = messageParts[1].split('Missing context keys: '); | |||
| error( | |||
| throw new Error( | |||
There was a problem hiding this comment.
There is a control flow difference between before vs after. Before, the error command did not terminate the control flow. After, throw terminates the control flow. Which one we want here?
There was a problem hiding this comment.
We want to throw. These errors that are thrown by CDK are fatal errors that prevent synthesis from completing. If we don't terminate here we end up with a very unhelpful error about not being able to read the cloud assembly.
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason trying to log an error using
errordoes not loganything. Also, we were not throwing the error so we were continuing
until it failed later with a different very unhelpful error message.
Instead of logging (since it doesn't work) just throw the error