Fixes debug logging of CfnResource #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, logging could generate "not supported" errors in the stream.
I1104 14:23:22.081768 66128 eventsink.go:59] CfnResource aws-native:ec2:SubnetRouteTableAssociation:
{"routeTableId":"Calling [toJSON] on an [Output<T>] is not supported.\n\nTo get the value of an Output as a JSON value
or JSON string consider either:\n 1: o.apply(v => v.toJSON())\n 2: o.apply(v => JSON.stringify(v))\n\nSee
https://www.pulumi.com/docs/concepts/inputs-outputs for more details.\nThis function may throw in a future version of
@pulumi/pulumi.","subnetId":"Calling [toJSON] on an [Output<T>] is not supported.\n\nTo get the value of an Output as a
JSON value or JSON string consider either:\n 1: o.apply(v => v.toJSON())\n 2: o.apply(v =>
JSON.stringify(v))\n\nSee https://www.pulumi.com/docs/concepts/inputs-outputs for more details.\nThis function may throw
in a future version of @pulumi/pulumi."}, ["awsId","routeTableId","subnetId"]
After the change, debug logging should happen only after the outputs are resolved.
There is a slight downside for unknowns - debug logging will not happen when some of the properties are unknown anymore,
because this will make `pulumi.output(x)` unknown and will not call `debug` in `apply`.
Note also that running programs under PULUMI_DEBUG_GRPC="$PWD/log.json" environment variable should also make it
possible to observe how the underlying resources are constructed in terms of calls to the backing provider, including
observing unknowns.
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, logging could generate "not supported" errors in the stream.
After the change, debug logging should happen only after the outputs are resolved.
There is a slight downside for unknowns - debug logging will not happen when some of the properties are unknown anymore, because this will make
pulumi.output(x)unknown and will not calldebuginapply.Note also that running programs under PULUMI_DEBUG_GRPC="$PWD/log.json" environment variable should also make it possible to observe how the underlying resources are constructed in terms of calls to the backing provider, including observing unknowns.