Convert the output of App.synth rather than the construct tree. #18
Assignees
Labels
Milestone
Comments
corymhall
added a commit
that referenced
this issue
Oct 1, 2024
Previously this library walked the construct tree in-memory and called the internal `_toCloudFormation()` method each `Cfn*` construct has to get the CloudFormation resource fragment. This is both inefficient (because we call `synth` which internally does the same thing, and then we do it again), and potentially inaccurate (`synth` internally does a lot more than we do when we walk the construct tree). This PR is a refactor (maybe closer to a rewrite) that switches to taking the output of `app.synth()` and processing the resulting CloudAssembly. The CloudAssembly has everything necessary to do the conversion and contains the fully resolved CloudFormation template (we don't have to worry about unresolved tokens!). This also sets us up for future work like nested stacks, multiple stacks, and #153. Note to reviewers. This is a pretty big refactor so I would recommend reviewing this instead as a restart rather than trying to figure out what the old code is doing. Closes #18
|
This issue has been addressed in PR #167 and shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just what it says on the tin. This should make for a more faithful conversion of the output of synthesis, and may make it more straightforward to support assets and other CDK features.
The text was updated successfully, but these errors were encountered: