Remove mappings to aws classic resources #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the manual mappings to aws classic resources that now exist in aws-native. BREAKING CHANGE: resources that were previously deployed with the `aws` provider are now deployed with the `aws-native` provider. This will cause resource replacement re #142
corymhall
force-pushed
the
corymhall/remove-classic-mappings
branch
from
3c75969 to
da9f689
Compare
corymhall
commented
Sep 6, 2024
tests/cdk-resource.test.ts
Outdated
There was a problem hiding this comment.
I'm not sure we need these types of tests, but I thought to try it out.
corymhall
commented
Sep 9, 2024
| debug(`Fn::GetAtt(${params[0]}, ${firstToLower(params[1])})`); | ||
| return this.resolveAtt(params[0], firstToLower(params[1])); | ||
| debug(`Fn::GetAtt(${params[0]}, ${params[1]})`); | ||
| return this.resolveAtt(params[0], params[1]); |
There was a problem hiding this comment.
Inside the resolveAtt function we use the toSdkName function which already handles name conversion. Using firstToLower here messed it up.
t0yv0
reviewed
Sep 9, 2024
| @@ -40,6 +39,9 @@ function tags(tags: pulumi.Input<pulumi.Input<CfnTags>[]> | undefined): AwsTags | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Any resource that does not currently exist in CCAPI can be mapped to an aws classic resource. | |||
t0yv0
reviewed
Sep 9, 2024
| ), | ||
| ); | ||
| return target; | ||
| } | ||
| // IAM | ||
| case 'AWS::IAM::Policy': { |
There was a problem hiding this comment.
Curious this is really not supported by Cloud Control API or is there another reason this maps to AWS classic?
There was a problem hiding this comment.
It's not fully supported in CCAPI (missing READ/LIST) so it is not supported by aws-native.
t0yv0
reviewed
Sep 9, 2024
| import { aws_ssm } from 'aws-cdk-lib'; | ||
|
|
||
| function setMocks(assertFn: (args: MockResourceArgs) => void) { | ||
| pulumi.runtime.setMocks( |
There was a problem hiding this comment.
Nice use of unit testing facility.
t0yv0
approved these changes
Sep 9, 2024
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the manual mappings to aws classic resources that now
exist in aws-native.
BREAKING CHANGE: resources that were previously deployed with the
awsprovider are now deployed with the
aws-nativeprovider. This willcause resource replacement
re #142