Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resource mappings to aws classic #142

Closed
corymhall opened this issue Aug 19, 2024 · 1 comment
Closed

Remove resource mappings to aws classic #142

corymhall opened this issue Aug 19, 2024 · 1 comment
Assignees
@corymhall
Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@corymhall
Copy link
Contributor

We should remove all mappings to aws classic resources that now have a native version. This will be a breaking change, but will make long term maintenance easier so it is something we should do prior to v1.

  • AWS::ApiGatewayV2::Api
  • AWS::ApiGatewayV2::Deployment
  • AWS::ApiGatewayV2::Route
  • AWS::DynamoDB::Table
  • AWS::EC2::EIP
  • AWS::EC2::SecurityGroup
  • AWS::EC2::SecurityGroupEgress
  • AWS::EC2::SecurityGroupIngress
  • AWS::EC2::VPCGatewayAttachment
  • AWS::ElasticLoadBalancingV2::LoadBalancer
  • AWS::ElasticLoadBalancingV2::TargetGroup
  • AWS::AutoScaling::AutoScalingGroup
  • AWS::AutoScaling::ScalingPolicy
  • AWS::EC2::Route
  • AWS::EC2::NatGateway
  • AWS::ApplicationAutoScaling::ScalableTarget
  • AWS::Lambda::Permission
  • AWS::S3::BucketPolicy
@corymhall corymhall added the impact/breaking Fixing this issue will require a breaking change label Aug 19, 2024
@corymhall corymhall self-assigned this Aug 19, 2024
@mikhailshilkov mikhailshilkov added the kind/enhancement Improvements or new features label Aug 19, 2024
corymhall added a commit that referenced this issue Sep 6, 2024
@corymhall
Remove mappings to aws classic resources
3c75969 
This PR removes the manual mappings to aws classic resources that now
exist in aws-native.

BREAKING CHANGE: resources that were previously deployed with the `aws`
provider are now deployed with the `aws-native` provider. This will
cause resource replacement

re #142
@corymhall corymhall mentioned this issue Sep 6, 2024
Merged
corymhall added a commit that referenced this issue Sep 6, 2024
@corymhall
Remove mappings to aws classic resources
da9f689 
This PR removes the manual mappings to aws classic resources that now
exist in aws-native.

BREAKING CHANGE: resources that were previously deployed with the `aws`
provider are now deployed with the `aws-native` provider. This will
cause resource replacement

re #142
corymhall added a commit that referenced this issue Sep 9, 2024
@corymhall
Remove mappings to aws classic resources (#163)
2e63bde 
This PR removes the manual mappings to aws classic resources that now
exist in aws-native.

BREAKING CHANGE: resources that were previously deployed with the `aws`
provider are now deployed with the `aws-native` provider. This will
cause resource replacement

re #142
@pulumi-bot pulumi-bot reopened this Sep 12, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikhailshilkov @cleverguy25 @pulumi-bot @corymhall