Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Docker assets #125

Closed
corymhall opened this issue May 24, 2024 · 1 comment · Fixed by #212
Closed

Support Docker assets #125

corymhall opened this issue May 24, 2024 · 1 comment · Fixed by #212
Assignees
@corymhall
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.113

Comments

@corymhall
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently we do not handle any docker image assets

pulumi-cdk/src/stack.ts

Lines 376 to 378 in 9718073

private convertDockerImage(id: string, asset: cloud_assembly.DockerImageAsset) {
debug('TODO: convert docker image asset');
}

We can probably add support via the docker provider.

Affected area/feature
@corymhall corymhall added impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features labels May 24, 2024
@corymhall corymhall mentioned this issue May 24, 2024
Closed
6 tasks
@mjeffryes mjeffryes added this to the 0.111 milestone Oct 2, 2024
@corymhall corymhall mentioned this issue Oct 4, 2024
Merged
@mjeffryes mjeffryes modified the milestones: 0.111, 0.112 Oct 30, 2024
@corymhall corymhall self-assigned this Nov 1, 2024
corymhall added a commit that referenced this issue Nov 12, 2024
@corymhall
Add docker image support
358f4b6 
This adds support for docker image assets by using the [pulumi/docker-build](https://github.com/pulumi/pulumi-docker-build) provider.

fixes #125
@corymhall corymhall mentioned this issue Nov 12, 2024
Merged
@mjeffryes mjeffryes modified the milestones: 0.112, 0.113 Nov 13, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 13, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #212 and shipped in release v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.113
Development

Successfully merging a pull request may close this issue.

Add docker image support pulumi/pulumi-cdk
3 participants
@mjeffryes @pulumi-bot @corymhall