Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where is the collect_fake_json.sh location in repo? #245

Open
chinhvc opened this issue Sep 24, 2024 · 1 comment · May be fixed by #263
Open

Where is the collect_fake_json.sh location in repo? #245

chinhvc opened this issue Sep 24, 2024 · 1 comment · May be fixed by #263

Comments

@chinhvc
Copy link

chinhvc commented Sep 24, 2024

From README.md, I found this section How do I run smartctl_exporter against a JSON file?

image

But I can not find collect_fake_json.sh script. Should I must create by my self or am I missing something?
@chennin
Copy link

chennin commented Oct 24, 2024

it was deleted in #176, and collect-smartctl-json.sh was created

robbat2 added a commit to robbat2/smartctl_exporter that referenced this issue Jan 8, 2025
@robbat2
feat: improve --smartctl.fake-data
648398d 
- Add `--smartctl.fake-data-path` to load data from other locations
- Cleanup documentation for fake data

Closes: prometheus-community#245
Signed-off-by: Robin H. Johnson <[email protected]>
@robbat2 robbat2 linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve --smartctl.fake-data robbat2/smartctl_exporter
2 participants
@chennin @chinhvc