Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Add some context to the handlers (e.g. log) #14

Open
karalabe opened this issue Sep 5, 2014 · 0 comments
Open

Add some context to the handlers (e.g. log) #14

karalabe opened this issue Sep 5, 2014 · 0 comments
Milestone

Comments

@karalabe
Copy link
Member

karalabe commented Sep 5, 2014

Currently in v1 the service/topic handlers work solely based on the binary data arriving from the network (broadcast, request, event). The issue is, that in the current API it is impossible to transfer the request context from the service layer up to the handler (think in terms of the contextual logger).

In the Java binding, the logger context can be carrier to the handler through the ThreadLocal, so it is covered, however Go doesn't have the notion of goroutine state, so maybe the binary blobs should be wrapped in some contextual struct containing the logger too.

Dunno, will have to ponder on this a bit.

@karalabe karalabe added this to the v2 milestone Sep 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant