Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property handling in showProjection #1218

Open
jamesmkrieger opened this issue Dec 15, 2020 · 0 comments
Open

Fix property handling in showProjection #1218

jamesmkrieger opened this issue Dec 15, 2020 · 0 comments
Labels
Enhancement Improvement to an already-existing feature.

Comments

@jamesmkrieger
Copy link
Contributor

We have had a number of problems with this, two of which I have attempted to solve in #1070 and #1073. I think the problem is that this function is a bit of a hybrid of plt.scatter and plt.plot with some custom things that don't make a lot of sense and may have got broken easily as a consequence. This may also be due to differences between the 2D and 3D versions of these functions.

It could be useful to look at the blame on this file (https://github.com/prody/ProDy/blame/master/prody/dynamics/plotting.py) and work out what changed when and why.

Here's an early version of the code using plt.plot for 2D and mpl_toolkits.mplot3d.Axes3D.plot for 3D, which very clean and simple using matplotlib to handle everything. Obviously, there are reasons for changes since this point, but it looks like a good model to strive for.
7023d3a#diff-766762f87f6dc7009128d2551201a6e3

@jamesmkrieger jamesmkrieger added Bug A problem with the code. and removed Bug A problem with the code. labels Dec 15, 2020
@jamesmkrieger jamesmkrieger added the Enhancement Improvement to an already-existing feature. label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an already-existing feature.
Projects
None yet
Development

No branches or pull requests

1 participant