Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files that are not pure Preact component exporters shouldn't create an HMR boundary #561

Open
tommie opened this issue Dec 1, 2024 · 0 comments

Comments

@tommie
Copy link

tommie commented Dec 1, 2024

I'm using Vite, but I think this applies to all backends.

A file that has "other stuff" than Preact components must let HMR reload the page, e.g. by not calling accept at all, or calling invalidate.

The Vite React Refresh plugin checks that all exports are components, and ignores the HMR request if there are non-components: vitejs/vite-plugin-react-refresh@feec176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant