Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card ripple #1203

Open
gopalramadugu opened this issue Jan 6, 2019 · 7 comments
Open

Card ripple #1203

gopalramadugu opened this issue Jan 6, 2019 · 7 comments
Milestone

Comments

@gopalramadugu
Copy link

Does the Card support the Card ripple effect ? The below link from Material io does support that. The ripple effect is on the Card it self. I am trying to create a pricing page. I would like offer the users to select with the ink ripple effect and show as selected once the user clicks the button.

https://material-components.github.io/material-components-web-catalog/#/component/card

@cromefire
Copy link
Collaborator

The ripple prop should do it.

@gopalramadugu
Copy link
Author

Is that a property on Card or card.media ? I am using a card with card.media that has an image background. Once the user click the image he directed to a new page. I tried ripple on both card and card.media. I have set it ripple={true}. But it doesn't work.

@cromefire
Copy link
Collaborator

It should be on every component.
In the demo the ripple is applied to the primary action:
devtools

@cromefire cromefire changed the title Card Selection Card ripple Jan 7, 2019
@gopalramadugu
Copy link
Author

I created a codepen https://codesandbox.io/s/6lo565y03w. I added the ripple ={true} but it doesnt work. Am I missing something ?

@cromefire
Copy link
Collaborator

No I schedule this for 2.0

@cromefire cromefire added this to the 2.0 milestone Jan 8, 2019
@gopalramadugu
Copy link
Author

Thank you @cromefire . Do we know the release date or planned release date for 2.0 ?

@cromefire
Copy link
Collaborator

No sorry, it's very depending on our time, I think first components might be in alpha in a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants