Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No osu! icon on Linux. #30810

Closed
DarkGradient opened this issue Nov 21, 2024 · 1 comment
Closed

No osu! icon on Linux. #30810

DarkGradient opened this issue Nov 21, 2024 · 1 comment

Comments

@DarkGradient
Copy link

DarkGradient commented Nov 21, 2024

Type

Cosmetic

Bug description

Fix osu!.desktop file: corrected Version and SingleMainWindow keys

  • Replaced Version=1.5 with Version=1.0 to comply with the Desktop Entry Specification.
  • Changed SingleMainWindow=true to X-SingleMainWindow=true as SingleMainWindow is a non-standard key.
  • How i found it: Decompited this .appimage, after that tried to recompile, and see errors.

What Lines Changed

X-SingleMainWindow=true
Version=1.0

This should fix osu!.Appimage icon for Linux
Srry, i don't know how to use pull requests :(

Screenshots or videos

image
Before --> After

Version

Latest

Logs

Runned command: ./appimagetool-x86_64.AppImage osu-root/
Output:
/home/hertz/not_error/AppImages/osu-root/osu!.desktop: error: value "1.5" for key "Version" in group "Desktop Entry" is not a known version

/home/hertz/not_error/AppImages/osu-root/osu!.desktop: error: file contains key "SingleMainWindow" in group "Desktop Entry", but keys extending the format should start with "X-"

This happens before fix. And i think this is a reason of missing icon on Linux.

@bdach
Copy link
Collaborator

bdach commented Nov 21, 2024

#30759

@bdach bdach closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants