Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External rings disappearing when moving #136

Open
flo-dup opened this issue Dec 10, 2024 · 1 comment
Open

External rings disappearing when moving #136

flo-dup opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@flo-dup
Copy link
Contributor

flo-dup commented Dec 10, 2024

Describe the current behavior

When moving a voltage levels with several rings, it sometimes occur that only the central circle is kept, the other rings disappear.

Describe the expected behavior

All the rings are drawn while moving.

Describe the steps

  • Chose a voltage level with several rings (buses)
  • Draw the diagram with a depth of 0
  • Move the voltage level

Environment

No response

Relevant Log Output

No response

Extra Information

No response

@flo-dup flo-dup added the bug Something isn't working label Dec 10, 2024
@flo-dup
Copy link
Contributor Author

flo-dup commented Jan 27, 2025

This is only happening on versions 1.5.0 and below. The refactoring done within the PR for v1.6.0 have solved this issue.

Nonetheless as this was not expected I think it's worth a try to investigate @massimo-ferraro. I pushed a new disappearing_rings branch with a unit test on top of v1.5.0: v1.5.0...disappearing_rings.

And more information about what's happening: when moving the node, the content of d parameter of the path of all the rings is emptied:

    <g class="nad-vl-nodes">
        <g transform="translate(16.31,-120.62)" id="0">
            <circle r="12.50" id="1" class="nad-vl300to500-0 nad-busnode"></circle>
            <path d="" id="2" class="nad-vl300to500-1 nad-busnode"></path>
            <path d="" id="3" class="nad-vl300to500-2 nad-busnode"></path>
            <path d="" id="4" class="nad-vl300to500-3 nad-busnode"></path>
        </g>
    </g>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: TODO
Development

No branches or pull requests

2 participants